[mc1322x] suggestions for code errata

[Mariano Alvira]

On Fri, Oct 09, 2009 at 01:17:46PM -0400, Peter Lawrence wrote:
> 
> 1) Line 344 of maca.c (set_power() function) looks suspect:
> 
> 	reg(ADDR_POW2) = (ADDR_POW1>>18) | PAVAL[power];
> 
> It just seems odd that one would write the MSBs of the value of the
> address of register POW1 into the register POW2.

Indeed it is odd. Please see

   http://git.devl.org/?p=malvira/mc1322x-tests.git;a=blob;f=doc/ws-dis
 
around line 6810 to see where this is coming from. It's very possible
I incorrectly interpreted the assembly.

> 2) XTAL_CNTL is not initialized
> 
> However, the RM suggests 0x15 coarse and 0x10 fine as starting values.
>  Using those, I experience much better reception of packets.
> 
> So, if you experience the same problems, it may be worth trying to
> write XTAL_CNTL with, say, the value of 0x28E0F52 to see if reception
> improves.

This is certainly fair. Thanks for the note. Has anyone come up with a
way to determine what these should be?

-Mar.